Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access static members in static fashion #22688

Merged
merged 1 commit into from
May 29, 2024
Merged

Access static members in static fashion #22688

merged 1 commit into from
May 29, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 7, 2024

Description

Don't treat static members as instance memebrs

Motivation and Context

This fixes an ugly race condition in JsonRenderer where different objects could overwrite each other's CODEC via shared static state.

Impact

none

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@elharo elharo marked this pull request as ready for review May 12, 2024 12:06
@elharo elharo requested review from jaystarshot, feilong-liu and a team as code owners May 12, 2024 12:06
@elharo elharo requested a review from presto-oss May 12, 2024 12:06
@tdcmeehan tdcmeehan merged commit 0a0ac8f into master May 29, 2024
57 checks passed
@elharo elharo deleted the staticmore branch June 4, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants