[native] Add native dynamic filter stats to operator stats for hbo #22734
Conversation
xiaoxmeng
force-pushed
the
hbo
branch
3 times, most recently
from
bd11e2d
to
7449fcd
Compare
|
I don't see documentation for me to review, perhaps I don't need to review this. Let me know if there's something I can help with! The description is empty, does this PR need a release note entry? |
xiaoxmeng
changed the title
xiaoxmeng
force-pushed
the
hbo
branch
8 times, most recently
from
a0287bf
to
4da1781
Compare
@steveburnett Hi, the pr description is updated. |
| @ThriftStruct | ||
| public class DynamicFilterStats | ||
| { | ||
| private final Set<PlanNodeId> producerNodeIds; |
There was a problem hiding this comment.
These PlanNodeIds will be the PlanNodeId of the joins which has dynamic filter pushdown?
How do we know which nodes these filters are pushed down to?
There was a problem hiding this comment.
DynamicFilterStats is set in operator stats of those nodes that has dynamic filters.
There was a problem hiding this comment.
For example, if we have a query plan like:
join <- (probe side) project <- filter <- scan
where the dynamic filter pushdown is enabled, we should have project, filter and scan all in the producerNodeIds, right?
There was a problem hiding this comment.
Synced offline, the plan node ids will be the where the dynamic filter is from, which is the join node in the example I showed above.
xiaoxmeng
force-pushed
the
hbo
branch
6 times, most recently
from
ff95670
to
9be885d
Compare
Exports the dynamic filter stats from native worker to coordinator: add DynamicFilterStats in OperatorStats and update presto protocol. Presto task collects the dynamic filter stats from velox.
amitkdutta
changed the title
Exports the dynamic filter stats from native worker to coordinator: