Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect trailingComma in angular templates #15926

Merged
merged 4 commits into from
May 28, 2024
Merged

Respect trailingComma in angular templates #15926

merged 4 commits into from
May 28, 2024
+761 −40

Conversation

fisker
Copy link
Member

@fisker fisker commented Jan 15, 2024

Description

Fixes #15897

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review January 15, 2024 12:41
@fisker fisker changed the title Respect trailingComma in angular template Respect trailingComma in angular templates Jan 16, 2024
@fisker fisker added this to the 3.3 milestone Jan 19, 2024
@sosukesuzuki
Copy link
Member

@fisker I Merge this, please revert if you have any problems.

@sosukesuzuki sosukesuzuki merged commit 8a88cdc into prettier:main May 28, 2024
25 of 26 checks passed
@fisker fisker deleted the trailing-comma branch May 28, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

Object literals in Angular templates are missing trailing commas
2 participants
@fisker @sosukesuzuki