Drop “display: none” from details element contents styling #2624
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 887edd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sideshowbarker
force-pushed
the
drop-display-none-from-details-contents-styling
branch
from
62952f8
to
887edd8
Compare
keithamus
approved these changes
May 9, 2024
There was a problem hiding this comment.
This was likely around for IE11 which we've long since dropped support for. Originally added in #371 in 2017.
As far as I can tell all browsers we see traffic GitHub support <details> and therefore don't need this. So 👍 from me.
sideshowbarker
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes #2592
What approach did you choose and why?
Removed
display: nonefromdetailscontents stylingWhat should reviewers focus on?
See #2592 (comment) for repro/test steps
Can these changes ship as is?