Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use es6 style #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use es6 style #27

wants to merge 2 commits into from

Conversation

boatnoodle
Copy link

I just want to help you make a code perfectly.

Copy link
Owner

@priyank-p priyank-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but I left one comment. Thanks for the PR!

Comment on lines +44 to +48
$evnetLog.innerHtml += `${readableDate} \n`
});

simplepicker.on('close', (date) => {
$eventLog.innerHTML += 'Picker Closed' + '\n';
$evnetLog.innerHtml += `Picker Closed \n`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name change here evnetLog from eventLog is wrong. It should be eventLog.innerHTML in both places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants