fixed-Incorrect lines when applying a stroke to geometry built without initial stroke-#6318

[Artimus100]

completely fixes the bug of issue #6318

Changes:
renderer._doStroke always true in the constructor of GeometryBuilder Class within GeometryBuilder.js

Screenshot:

PR Checklist

• npm run lint passes
• Inline documentation is included / updated
• Unit tests are included / updated

[Artimus100]

@davepagurek please review it!!

[davepagurek]

Thanks for taking this on!

Have you tried doing any testing on how long it takes to before/after this change when creating geometry with lots of edges but with noStroke()? I think that's one of the risks of introducing this, where if the time difference is significant, we might need to also add a setting to ignore strokes for performance reasons.

Also, it would be great to add a test for this so we can be sure this doesn't break in the future. We also have just merged visual tests which might be a good fit here.

[Artimus100]

@davepagurek ill get back to you with that data!!

[Artimus100]

Hello @davepagurek should i mail you a doc with the time difference or just comment here so that you can look at it and tell me if we need to add the setting to ignore strokes for the performance reasons and ill start working on the tests right away!!

[davepagurek]

I think commenting here would be great so that anyone else following the discussion can see the data too. We're also talking about adding a settings object as a parameter to buildGeometry/beginGeoemtry in #6722, so maybe if it turns out we need it, we can add a setting like buildGeometry({ includeStroke: false }).