-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add windows amd64 to goreleaser config #388
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 33.02% 33.02%
=======================================
Files 17 17
Lines 1626 1626
=======================================
Hits 537 537
Misses 1060 1060
Partials 29 29 ☔ View full report in Codecov by Sentry. |
ea6e033
to
6bc971a
Compare
@benbp curious, did you test patching under windows? i am guessing you are targeting linux containers, as copa won't work for windows containers |
Correct, I'm still targeting linux containers. I haven't tested patching, I will do so and report back. |
@benbp Any results from trying to patch an image on Windows? |
@salaxander I had it working last week, but just for a scenario where no patches had to be made. I was running into some trouble actually patching an image, but believe it was related to the yum cache on my test image, not copa. Need to come back around to it, I don't actually have a good windows machine setup myself for testing this so dependent on others for it.
|
Ideally, we should have a test for this in the CI if we want to officially support this. Darwin binaries are missing this too (#405) |
@salaxander @sozercan success (Docker Desktop for windows v4.25.0, Windows 11, WSL2 engine enabled)
|
7af0774
to
4d762d8
Compare
Signed-off-by: Ben Broderick Phillips <bebroder@microsoft.com>
4d762d8
to
3020af3
Compare
Adds windows+amd64 to the release configuration so copa can run on windows OS (but still target a linux container).
Tested:
Runs locally using snapshot build: