feat: Add a new .devcontainer #465
Open
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinz
requested review from
jeremyrickard,
salaxander and
sozercan
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
=======================================
Coverage 32.59% 32.59%
=======================================
Files 17 17
Lines 1617 1617
=======================================
Hits 527 527
Misses 1058 1058
Partials 32 32 ☔ View full report in Codecov by Sentry. |
sozercan
requested changes
Jan 8, 2024
| @@ -0,0 +1,21 @@ | |||
| { | |||
| "name": "copacetic", | |||
| "image": "mcr.microsoft.com/devcontainers/base:jammy", | |||
There was a problem hiding this comment.
nit: can we use ubuntu22.04 instead of jammy
| ] | ||
| } | ||
| } | ||
| } |
|
|
||
| sudo chown -R vscode:vscode . | ||
|
|
||
| make |
| @@ -0,0 +1 @@ | |||
| * text=lf | |||
| @@ -0,0 +1,5 @@ | |||
| curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sudo sh -s -- -b /usr/local/bin v0.48.2 | |||
There was a problem hiding this comment.
can we install from apt or github release instead of curl | sudo sh
we can also add this to Makefile for a devcontainer specific target and have version as a variable so we don't have to update in multiple places in the future
|
@jpinz please make sure to sign your commits (see DCO failure) https://project-copacetic.github.io/copacetic/website/contributing#developer-certificate-of-origin-dco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the development environment configuration. The most important changes are the addition of a new development container configuration, a post-creation script for the development container, and a
.gitattributesfile to enforce line endings.Development container configuration:
.devcontainer/devcontainer.json: A new development container configuration has been added. The container is named "copacetic" and is based on themcr.microsoft.com/devcontainers/base:jammyimage. It includes Docker-in-Docker and Go features, runs a post-creation script, sets the remote user to "vscode", and installs several VS Code extensions.Post-creation script:
.devcontainer/post-create.sh: A post-creation script for the development container has been added. It installs the Trivy security scanner, changes the ownership of all files in the current directory to "vscode", and runs themakecommand.Line endings enforcement:
.gitattributes: A new.gitattributesfile has been added to enforce LF line endings for all text files.