feat: Add guardrails for parsing OS version #619
+46
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: h4l0gen <ks3913688@gmail.com>
h4l0gen
requested review from
jeremyrickard,
sozercan and
ashnamehrotra
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
==========================================
+ Coverage 32.51% 33.92% +1.41%
==========================================
Files 17 18 +1
Lines 1621 1518 -103
==========================================
- Hits 527 515 -12
+ Misses 1062 970 -92
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
|
Hey sorry, as per this we need to run golangci-lint too, i will run it and make required changes if any. |
Signed-off-by: Kapil Sharma <ks3913688@gmail.com>
h4l0gen
changed the title
h4l0gen
changed the title
ashnamehrotra
requested changes
May 13, 2024
| osVersion := strings.Join(versionParts[:2], ".") | ||
| return "ubuntu", osVersion, nil | ||
| } | ||
| return "", "", fmt.Errorf("invalid Ubuntu version format: %s", osData["VERSION_ID"]) |
There was a problem hiding this comment.
can we add this check in getAptImageName if the os.Type is Debian instead?
| @@ -301,34 +301,40 @@ func patchWithContext(ctx context.Context, ch chan error, image, reportFile, pat | |||
| return eg.Wait() | |||
| } | |||
|
|
|||
| func getOSType(ctx context.Context, osreleaseBytes []byte) (string, error) { | |||
| func getOSType(ctx context.Context, osreleaseBytes []byte) (string, string, error) { | |||
There was a problem hiding this comment.
since a lot of the work is repeated with getOSVersion, maybe we can combine the two functions into one and remove getOSVersion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding guardrails for parsing OS version as per discussion
Closes #438