Update for sdk asynchronous issue #715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsandeep
requested changes
Jan 5, 2024
There was a problem hiding this comment.
@Serhatcck can you please rebase the PR from dev branch for further review!
|
Hi @ehsandeep. I rebase at this address: #717 |
|
@Serhatcck I'm closing this PR as it seems the most up to date is #717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran Katana as an SDK, it was only crawling a single URL. Upon investigating, I found that it was due to the 'Do' function in 'pkg/engine/common/base.go.' The structure for asynchronously adding data to the queue wasn't working in conjunction with the for loop. The for loop wasn't waiting for the result of the asynchronous function, so when a new value arrived in the queue, the for loop had already completed. To resolve this, I submitted this pull request.
Issue link: #714
I've provided necessary explanations at the location where the issue is located.