Fire keyup events for ActionEventBus.keys on document blur #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somaraani
changed the title
|
might be better to use, as it covers all cases and not just blur. Can you give this a test? |
|
|
||
| document.addEventListener('keyup', this.keyUp); | ||
| document.addEventListener('keydown', this.keyDown); | ||
| document.addEventListener('blur', this.blur); |
There was a problem hiding this comment.
see other comments, also this needs to be deregistered in unmount
| @@ -80,4 +80,10 @@ export class ActionEventBus { | |||
| action.options.fire(actionEvent as any); | |||
| } | |||
| } | |||
|
|
|||
| clearKeys() { | |||
| _.forEach(Object.keys(this.keys), (key) => { | |||
There was a problem hiding this comment.
dont need the Object.keys, _.forEach will give the key as the second param in the callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn run prettyWhat?
Fire key-up events for all keys in action event bus on document blur
Why?
#919
How?
Iterate through
ActionEventBus.keysand fire keyup event on document blur.Feel good image:
(Add your own one below :])