Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/csv import #232

Closed

Conversation

shouryan01
Copy link
Collaborator

Description

Adds UI for uploading .csv files

What type of PR is this? (check all applicable)

  • [x ] πŸ’‘ Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

continues work on #196

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

vercel bot commented Apr 13, 2024

@shouryan01 is attempting to deploy a commit to the Salgsmaskin Team on Vercel.

A member of the Team first needs to authorize it.

@shouryan01
Copy link
Collaborator Author

Writing parsing functions was time consuming

Luckily, I found a library which did what I initially had in mind for making the users do the data classification for us. Now you can upload a .csv file, it will try to map the columns for "Date", "Description" and "Amount". If there is not a column match, the user can manually match. The processed rows are displayed in the console.

image image

@Codehagen
Copy link
Member

This looks very promising! Think this is the way to go, and we would also not need each person to added their bank. This will be a lot more dynamic ✨

@shouryan01
Copy link
Collaborator Author

Yeah @meglerhagen that was the idea!

Now I had a question about mobile users: having that interface on a mobile sized screen is not a great experience; we'd need to build something from scratch for that use case.

But I was thinking: we could just disable manual file uploads from mobile sized screens? I checked with Bank of America and Chase, and both their mobile apps don't have a way to export transactions like their desktop counterparts do.

Therefore:

  1. It would take a few days to build the mobile UI, time better spent on other areas
  2. My hypothesis is that not many users would even use mobile phones for file manipulations because iOS file manager is clunky at best
  3. There doesn't seem a way to export transactions easily from apps anyway

What do you think? If they want manual uploads we can just direct them to the website

@Codehagen
Copy link
Member

I agree with your approach. Lets disable it for mobile for now, even though we don't disable it its no problem. Minior fixes can the community also help with, while you do some heavy lifting πŸ‹οΈ

@shouryan01 shouryan01 closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants