[kube-prometheus-stack] Update mixins, switch to kube-prometheus mixin and fix label aggregation in TargetDown alert #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
mrueg
reviewed
Apr 18, 2024
|
Hi @jkroepke, sorry it took too long to review :/ please fix the conflicts and I'll take another look. |
jkroepke
force-pushed
the
TargetDown-aggregation-label
branch
2 times, most recently
from
0fbfa92
to
ad09025
Compare
jkroepke
changed the title
jkroepke
force-pushed
the
TargetDown-aggregation-label
branch
from
ad09025
to
a2736d7
Compare
…n and fix label aggregation in TargetDown alert Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
jkroepke
force-pushed
the
TargetDown-aggregation-label
branch
from
a2736d7
to
db75221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Switch to jsonnet which generates all rules now by default (including the new grafana one)
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])