[kube-prometheus-stack] fix the retentionSize value #4533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karloramone
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
Signed-off-by: karloramone <karlo.krupljan@gmail.com>
Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com>
|
@karloramone where in the docs does it state that you can only configure one or the other? You can define both and Prometheus makes it an or between retention time and retention size. You can set the value to nil in your values if you do not want it |
|
I'm closing here as this is not a bug, feel free to reopen otherwise |
|
@QuentinBisson Yes, looks like I misunderstood the docs and had some other problem. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
There is a bug in the chart related to the
prometheus.prometheusSpec.retentionSizevalue.In the default values currently there is specified value for
prometheus.prometheusSpec.retention: 10d.When you try to add the value
prometheus.prometheusSpec.retentionSizeit will also generate theprometheus.prometheusSpec.retention: 10dfrom those default values.This is a problem because according to the docs only one of those values can be configured.
Checklist
[prometheus-couchdb-exporter])