try if trust-dns-resolver works or not #190
Conversation
There was a problem hiding this comment.
I'm generally fine with adding examples like that, but could you create a new example instead of overloading the existing one with unrelated test code?
Also, the outgoing DNS request won't be sent, since Proxy-Wasm doesn't yet allow TCP/UDP sidecalls. Did you try to use this code in Envoy or another host implementation?
| let io_loop = Runtime::new().unwrap(); | ||
| let lookup = io_loop.block_on(lookup).unwrap(); |
There was a problem hiding this comment.
This seems like a bad idea, since each worker thread (in case of Envoy) is going to be blocked on this, and DNS resolution can potentially take hundreds of milliseconds... not to mention the overhead of starting Tokio runtime per each request.
There was a problem hiding this comment.
Can we have a meeting about this? Can we mitigate the overhead per request by cache layer?
There was a problem hiding this comment.
You could store the runtime in a global variable and share it across the callbacks, but I suspect that Tokio runtime couldn't make any progress without deep integration with Proxy-Wasm's callbacks.
Also, if you try to compile your example, you can see that Tokio async doesn't work in Wasm (yet):
compile_error!("Only features sync,macros,io-util,rt,time are supported on wasm.");
What are you trying to achieve? What's your end goal?
There was a problem hiding this comment.
yup... I can not compile through for that reason. I am trying to get cname chain in WASM. Could you recommend some feasible way? I saw there are some other lib besides Tokio, like RustDNS maybe others but not sure if they have similar issue. It will be nice if you can suggest
There was a problem hiding this comment.
Are you interested only in the final answer or the whole CNAME chain? If the former, and you're using Envoy, then there are envoy_resolve_dns / envoy_on_resolve_dns extensions that you could call and use Envoy's built-in DNS resolver... Note that they are not exposed in the Rust SDK yet.
No description provided.