Reads in webserver secret_key at runtime #512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankcash
force-pushed
the
webserver-secret
branch
from
624ea2b
to
2f62271
Compare
Fixes spacing
|
👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Generate the
webserversecret_keyin theentrypoint.shThis will be helpful if people run in a multi tenant mode with auth.
Previously if you had multiple instances running with auth and didn't change the secret (i.e. you forgot to or didn't realize you needed to) you would be able to jump from cluster to cluster because the session would be valid once authorized for the first time.
Previous Behavior
in section
webserversecret_keydefaults totemporary_keyCurrent Behavior
secret_key is uniquely generated at run time