-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add #on_stopped
DSL (re: discussion/3379)
#3380
base: master
Are you sure you want to change the base?
Conversation
LGTM |
@options[:on_stopped] ||= [] | ||
@options[:on_stopped] << block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks different to other events. And a simple test in config shows it's being ignored completely. On the other hand, delegating this to events seem to work.
@options[:on_stopped] ||= [] | |
@options[:on_stopped] << block | |
@config.options[:events].on_stopped(&block) |
def test_run_hooks_on_stopped_hook | ||
assert_run_hooks :on_stopped | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the change above, the test should probably mirror test_on_booted
instead.
Description
This change adds the
#on_stopped
method to Puma's DSL, to match the functionality provided by#on_booted
. Since this DSL method is documented, its absence appears to be a simple oversight, and it seems appropriate to have.Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.