New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: providing null to page.authenticate should disable authentication #12203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning00Blade
force-pushed
the
fix-authentication
branch
from
April 4, 2024 09:51
425c97d
to
d910f36
Compare
Lightning00Blade
commented
Apr 4, 2024
|
Lightning00Blade
changed the title
fix: disabling of authentication
fix: providing null to page.authenticate should disable authentication
Apr 4, 2024
OrKoN
approved these changes
Apr 4, 2024
Lightning00Blade
force-pushed
the
fix-authentication
branch
from
April 4, 2024 10:53
d886b7e
to
e21e9b1
Compare
OrKoN
force-pushed
the
main
branch
4 times, most recently
from
April 16, 2024 09:37
2ff1e4f
to
e0932e5
Compare
Lightning00Blade
force-pushed
the
fix-authentication
branch
from
April 26, 2024 12:18
e21e9b1
to
886fe18
Compare
Testing again with 125.0.6422.14 seems to work so waiting till that or newer version rolls to stable to re test. |
@Lightning00Blade can this be landed? |
ah waiting for m125 |
Lightning00Blade
force-pushed
the
fix-authentication
branch
from
May 21, 2024 14:27
886fe18
to
39cf0b4
Compare
Lightning00Blade
force-pushed
the
fix-authentication
branch
from
May 21, 2024 15:42
3eba604
to
14b8621
Compare
Lightning00Blade
force-pushed
the
fix-authentication
branch
from
May 21, 2024 20:23
14b8621
to
800ba0a
Compare
Lightning00Blade
force-pushed
the
fix-authentication
branch
from
May 22, 2024 10:52
800ba0a
to
6532abe
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns with our documentation that tell's we can use
null
to disable,Providing
user/pass
withundefined
did not disable theFetch
domain as it should.