Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatree design discussions - weekly meeting #8747

Open
1 of 11 tasks
TomNicholas opened this issue Feb 14, 2024 · 10 comments
Open
1 of 11 tasks

Datatree design discussions - weekly meeting #8747

TomNicholas opened this issue Feb 14, 2024 · 10 comments
Labels
community topic-DataTree Related to the implementation of a DataTree class

Comments

@TomNicholas
Copy link
Contributor

TomNicholas commented Feb 14, 2024

What is your issue?

In the bi-weekly dev meeting today we agreed that deliberate higher-level discussions of datatree's design would be useful. (i.e. we're not worried about our ability to write high-quality code, so let's focus review time more explicitly on the high-level design questions.)

This could take the form of me just talking through what I did in a certain part of the code and why, or a targeted discussion on specific design questions that I was never quite sure about. Some examples of the latter, as food for thought:

There was also this design doc I wrote at one point

@flamingbear are you free at 11:30am EST on Tuesday each week? @shoyer, @keewis and I are all free then. Others also welcome (e.g. @owenlittlejohns , @eni-awowale, @etienneschalk), but not required :)

@TomNicholas TomNicholas added community topic-DataTree Related to the implementation of a DataTree class labels Feb 14, 2024
@TomNicholas TomNicholas added this to To do in DataTree integration via automation Feb 14, 2024
@flamingbear
Copy link
Contributor

@TomNicholas Yes, I'm good on 11:30am EST Every Tuesday.

@eni-awowale
Copy link
Contributor

Thanks for putting this together @TomNicholas! 11:30 EST on Tuesdays should generally work for me.

@TomNicholas
Copy link
Contributor Author

TomNicholas commented Feb 14, 2024

Great. 11:30am-12:00am EST every week it is then! (We can overrun if necessary, but prioritize agenda items so as to respect people's time who can't stay for longer.)

Google calendar event link (There is an xarray calendar but I don't think I have access to it)

We'll use the same zoom link as for the bi-weekly dev call.

Meeting notes

@flamingbear
Copy link
Contributor

flamingbear commented Feb 14, 2024

Google calendar event link (There is an xarray calendar but I don't think I have access to it)

FYI I can't open this calendar link.

@dcherian dcherian pinned this issue Feb 15, 2024
@TomNicholas
Copy link
Contributor Author

FYI I can't open this calendar link.

Ugh - I tried changing the account which owns the event, but if that still doesn't work then just forget about it. I'll post here if we need to cancel or change the time or anything.

@TomNicholas
Copy link
Contributor Author

TomNicholas commented Feb 20, 2024

Following up from our discussion today (@shoyer @owenlittlejohns @keewis @flamingbear) the original issue about storing xr.Variable objects rather than xr.Dataset objects is here: xarray-contrib/datatree#2 (comment). My actual reasoning is recorded in this comment xarray-contrib/datatree#2 (comment), but this is not set in stone!

@TomNicholas
Copy link
Contributor Author

I can't make the normal time of 11:30am EST tomorrow (it clashes with a job talk I need to attend).

The only other time tomorrow I could do is 1 hour earlier (10:30am EST). I'll be on zoom then anyway in case anyone shows up!

@shoyer @flamingbear @eni-awowale @owenlittlejohns

@schlich
Copy link

schlich commented Apr 3, 2024

I'd like to pop in and be a fly on the wall of these meetings if they're still happening... lmk

@TomNicholas
Copy link
Contributor Author

@schlich yes they are still happening! You missed one yesterday in fact. You're welcome to pop in.

@schlich
Copy link

schlich commented Apr 3, 2024

Wonderful, it's in my calendar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community topic-DataTree Related to the implementation of a DataTree class
Projects
Development

No branches or pull requests

4 participants