-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Integrate sphinx-issues
into the Sphinx config
#12616
base: main
Are you sure you want to change the base?
Conversation
I have a feeling that request will be rejected as being out of the scope. The extension seems to be focused on the issue trackers. |
I feel the same. It would be more widely applicable if it could be changed to sphinx-links or similar, but I don't think that's possible. |
My pull request sloria/sphinx-issues#145 to support role |
Now it's ready for review. |
I'm not convinced that it's worth the extra dependency (granted it's tiny) to remove only a few lines of static Sphinx configuration, but I suppose standardization of the role names (and any new ones) could be a benefit? I'll note that Ultimately I'm neutral on the change. |
@ichard26 yes, standardization is key. Plus, it's one thing less to copy over through many projects for people who tend to maintain many and sync them periodically. It also exposes a few other roles for free. |
@shenxianpeng now that you removed the entire setting, could you also drop the extension from the |
closes #12551
issue
andpull
, only leftpypi
because sphinx-issues not support rolepypi
now, but I have created Add new role:pypi:
sloria/sphinx-issues#145 to let it supportspull
topr
in NEWS.rst to fix the errorNEWS.rst:3614: ERROR: Unknown interpreted text role "pull".