Calculate candidate string versions only once in get_applicable_candidates
#12664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
force-pushed
the
Calculate-candidate-versions-once-in-`get_applicable_candidates`
branch
from
eb7c1eb
to
3ddec7f
Compare
|
Found one further minor improvement, Other than that this logic is quite sensitive due to the complicated way prereleases work in the version spec, so I wasn't able to find any other big improvements, except when Marking ready for review. |
|
Updated now Python 3.13 is passing CI |
ichard26
approved these changes
Jun 1, 2024
notatallshaw
force-pushed
the
Calculate-candidate-versions-once-in-`get_applicable_candidates`
branch
from
e0bcee2
to
d845ad9
Compare
uranusjr
reviewed
Jun 3, 2024
| # types. This way we'll use a str as a common data interchange | ||
| # format. If we stop using the pkg_resources provided specifier | ||
| # and start using our own, we can drop the cast to str(). | ||
| candidates_and_versions = [(c, str(c.version)) for c in candidates] |
There was a problem hiding this comment.
Do we know how much memory overhead this may induce in a large install? I agree this block can likely be further optimised since it is basically filtering on one list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor performance, I measure it at 1% fairly consistently across different resolutions I've tried.
I was looking at the "After call graph" in #12663 and noticed that
get_applicable_candidateswas taking 16% of run time, and even though it was only called 921 times it is calling other methods hundreds of thousands of times.The only obvious thing I spotted though is it effectively calculating
[c.version for c in candidates]twice, and can be seen on this part of the call graph:Highlighted call graph
I suspect though that this function has further significant optimization, so I will leave it as draft for now and think on it and take any suggestions, before marking it ready for review.