Upgrade truststore to 0.9.1 #12707
Open
Upgrade truststore to 0.9.1 #12707
+55
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
May 20, 2024
|
Thank you for the review @uranusjr! |
|
@sethmlarson Could you rebase/merge in main to pull in the CI fixes? |
sethmlarson
force-pushed
the
truststore-0.9.1
branch
from
b13ebec
to
44c2f4a
Compare
|
@ichard26 Done! |
|
Strange that pre-commit CI is failing, but could you also fix that? (I would fix it myself, but I'm not a pip committer and I can't push to your branch, sorry.) |
sethmlarson
force-pushed
the
truststore-0.9.1
branch
from
44c2f4a
to
2000d38
Compare
|
@ichard26 Fixed the issue and repushed, sorry for that! |
|
To committers, any objections if this lands for 24.1 final? This was supposed to be in the release, but undiscovered Python 3.13 incompatibilities led to a revert. If it's too risky, I'd like to see this land in 24.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #12662 which fixes the issue discovered after 0.9.0 was vendored (thanks @notatallshaw for reporting that issue!)