New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ET-VK][15/n] reconcile Dim4D and NchwDim #3489
Conversation
TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3489
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 155b61b with merge base c001f59 (): BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D56778340 |
TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) ghstack-source-id: 224867963 Pull Request resolved: #3489
TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) [ghstack-poisoned]
Pull Request resolved: #3489 TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) ghstack-source-id: 225119612
This pull request was exported from Phabricator. Differential Revision: D56778340 |
TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) [ghstack-poisoned]
Pull Request resolved: #3489 1. Adapt @SSJia's idea to represent `Dim4D` as a "negative index", and rename it as `DimIndex` 2. Merge `NchwDim`'s functionality with `Dim4D`. 3. Clean up `dim_at` call to assume only `DimIndex` as input. 4. Further clean up some usage of `uint` and convert them into `int`. ghstack-source-id: 225120658 Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/)
This pull request was exported from Phabricator. Differential Revision: D56778340 |
TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) [ghstack-poisoned]
Pull Request resolved: #3489 1. Adapt @SSJia's idea to represent `Dim4D` as a "negative index", and rename it as `DimIndex` 2. Merge `NchwDim`'s functionality with `Dim4D`. 3. Clean up `dim_at` call to assume only `DimIndex` as input. 4. Further clean up some usage of `uint` and convert them into `int`. ghstack-source-id: 225521662 Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/)
This pull request was exported from Phabricator. Differential Revision: D56778340 |
This pull request has been merged in 251aa74. |
Stack from ghstack (oldest at bottom):
TSIA.
Differential Revision: D56778340