New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use c++11 for size test #3509

Closed

lucylq wants to merge 1 commit into main from lfq.size-test-c11

Contributor

lucylq commented May 3, 2024

No description provided.

pytorch-bot bot commented May 3, 2024 •

edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3509

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit bda27d2 with merge base f9db02a ():

NEW FAILURES - The following jobs have failed:

pull / unittest / linux (buck2) / linux-job (gh)
backends/arm/test/ops/test_view.py::TestSimpleView::test_view_tosa_BI_1
pull / unittest / macos (buck2) / macos-job (gh)
backends/arm/test/ops/test_view.py::TestSimpleView::test_view_tosa_BI_1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

lucylq force-pushed the lfq.size-test-c11 branch from b7006f3 to 8d66fe5 Compare

May 3, 2024 23:40

Contributor

facebook-github-bot commented May 6, 2024

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request


          Use c++11 for size test (#3509)

Summary: Pull Request resolved: #3509

Differential Revision: D57003591

Pulled By: lucylq

facebook-github-bot force-pushed the lfq.size-test-c11 branch from 8d66fe5 to 2633953 Compare

May 6, 2024 16:48

Contributor

facebook-github-bot commented May 6, 2024

This pull request was exported from Phabricator. Differential Revision: D57003591

facebook-github-bot added the fb-exported label

facebook-github-bot pushed a commit that referenced this pull request


          Use c++11 for size test (#3509)

a8596ec

Summary: Pull Request resolved: #3509

Differential Revision: D57003591

Pulled By: lucylq

facebook-github-bot force-pushed the lfq.size-test-c11 branch from 2633953 to a8596ec Compare

May 6, 2024 19:48

Contributor

facebook-github-bot commented May 6, 2024

This pull request was exported from Phabricator. Differential Revision: D57003591

facebook-github-bot pushed a commit that referenced this pull request


          Use c++11 for size test (#3509)

4fb2169

Summary: Pull Request resolved: #3509

Differential Revision: D57003591

Pulled By: lucylq

facebook-github-bot force-pushed the lfq.size-test-c11 branch from a8596ec to 4fb2169 Compare

May 6, 2024 20:15

Contributor

facebook-github-bot commented May 6, 2024

This pull request was exported from Phabricator. Differential Revision: D57003591

lucylq marked this pull request as ready for review

May 6, 2024 20:43

lucylq requested review from mergennachin and swolchok

May 6, 2024 21:45

swolchok approved these changes

View reviewed changes

Contributor

swolchok left a comment

I don't love the string_view changes from an aesthetic perspective, but they do look necessary.

facebook-github-bot pushed a commit that referenced this pull request


          Use c++11 for size test (#3509)

f592ffa

Summary: Pull Request resolved: #3509

Reviewed By: swolchok

Differential Revision: D57003591

Pulled By: lucylq

facebook-github-bot force-pushed the lfq.size-test-c11 branch from 4fb2169 to f592ffa Compare

May 7, 2024 00:27

Contributor

facebook-github-bot commented May 7, 2024

This pull request was exported from Phabricator. Differential Revision: D57003591

facebook-github-bot pushed a commit that referenced this pull request


          Use c++11 for size test (#3509)

ffc42c5

Summary: Pull Request resolved: #3509

Reviewed By: swolchok

Differential Revision: D57003591

Pulled By: lucylq

facebook-github-bot force-pushed the lfq.size-test-c11 branch from f592ffa to ffc42c5 Compare

May 7, 2024 00:38

Contributor

facebook-github-bot commented May 7, 2024

This pull request was exported from Phabricator. Differential Revision: D57003591

mergennachin approved these changes

View reviewed changes


          Use c++11 for size test (#3509)

bda27d2

Summary: Pull Request resolved: #3509

Reviewed By: mergennachin, swolchok

Differential Revision: D57003591

Pulled By: lucylq

facebook-github-bot force-pushed the lfq.size-test-c11 branch from ffc42c5 to bda27d2 Compare

May 8, 2024 16:51

Contributor

facebook-github-bot commented May 8, 2024

This pull request was exported from Phabricator. Differential Revision: D57003591

facebook-github-bot pushed a commit that referenced this pull request


          Use c++11 for size test (#3509)

d30fd4c

Summary: Pull Request resolved: #3509

Reviewed By: mergennachin, swolchok

Differential Revision: D57003591

Pulled By: lucylq

facebook-github-bot closed this in

b0c0e30

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented May 8, 2024

@lucylq merged this pull request in b0c0e30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment