Add missing type uint16, uint32, and uint64 to TensorHash in LTC. #125972
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125972
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 31cff15 with merge base ee804d2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
hey @JackCaoG , could you approve the CI? I want to find out where I can add a test for my change. I've checked myforks/pytorch/test/cpp/lazy/test_misc.cpp but it doesn't seem to trigger the function |
|
Hi @JackCaoG , could you take another look at the PR? I was searching for the place to add a test but couldn't find any in Pytorch. Since pytorch CI runs pytorch/xla tests and one of the pytorch/xla tests exercise the case, I think we can leverage that. Thanks! |
|
Give me another ping when CI is green |
|
hey @JackCaoG , the CI is green. |
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…torch#125972) If I do: ``` xla_device = xm.xla_device() xla_tensor_0 = torch.tensor(42, dtype=torch.uint32).to(xla_device) ``` I got the error: ``` RuntimeError: false INTERNAL ASSERT FAILED at "/ansible/pytorch/torch/csrc/lazy/core/hash.h":139, please report a bug to PyTorch. Unsupported scalar type:UInt16 ``` This PR intends to fix this issue. The data type can be found in pytorch/c10/core/ScalarType.h. Pull Request resolved: pytorch#125972 Approved by: https://github.com/JackCaoG
If I do:
I got the error:
This PR intends to fix this issue.
The data type can be found in pytorch/c10/core/ScalarType.h.