Fix sync on index_select decomposition when the index has one element #125973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix was not general enough. Fixes #125952 [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125973
Note: Links to docs will display an error until the docs builds have been completed. ❌ 24 New FailuresAs of commit 001ca95 with merge base 2ed17e0 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
reviewed
May 11, 2024
| @@ -4020,10 +4020,10 @@ def index_select(x: TensorLike, dim: int, index: TensorLike): | |||
| ) | |||
| if index.ndim == 0: | |||
| index = index.unsqueeze(0) | |||
| if x.ndim == 0: | |||
| if x.numel() == 1: | |||
| # Treat scalars as elements of \R^1 | |||
| # We cannot use x[idx] here as it accesses item() (??), hence this awkward construction | |||
There was a problem hiding this comment.
Do we know why this happens?!
There was a problem hiding this comment.
Can we add an operator that is like x[idx] but instead produces a copy rather than view?
|
This seems reasonable but I guess it doesn't work? |
|
The roll error is fine, but that pdist error I'll have to look into. I'll spin up an A100 box next week and make sure the fix I submit works lol |
|
This does not appear to fix it: 
|
|
And it's also difficult to tell how this could fix it, the trace appears to originate from C++ code |
|
I thought the issue was coming from the use of index_select and its decomposition dispatching to advanced indexing, which sometime synchronizes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The previous fix was not general enough.
Fixes #125952