Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo in documentation #125974

Closed
wants to merge 2 commits into from
Closed

fixed typo in documentation #125974

wants to merge 2 commits into from

Conversation

shazqadeer
Copy link
Contributor

Summary: Fixed typo in documentation. Trying to get familiar with the PR workflow for contributing to PyTorch.

Test Plan: None

Reviewers:

Subscribers:

Tasks:

Tags:

Fixes #ISSUE_NUMBER

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@shazqadeer shazqadeer requested a review from ezyang May 10, 2024 22:55
Copy link

pytorch-bot bot commented May 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125974

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 727ed03 with merge base d7fe3c4 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

linux-foundation-easycla bot commented May 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@ezyang
Copy link
Contributor

ezyang commented May 11, 2024

You accidentally updated submodule. https://fb.workplace.com/groups/1144215345733672/posts/2585581408263718 will help

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@shazqadeer
Copy link
Contributor Author

You accidentally updated submodule. https://fb.workplace.com/groups/1144215345733672/posts/2585581408263718 will help

Thanks. I reverted the change.

@ezyang
Copy link
Contributor

ezyang commented May 11, 2024

Check https://github.com/pytorch/pytorch/wiki/Bot-commands#merge for how to merge it yourself

@shazqadeer
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 13, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@shazqadeer
Copy link
Contributor Author

@pytorchbot label "release notes: documentation for constrain_as_size fixed"

Copy link

pytorch-bot bot commented May 13, 2024

Didn't find following labels among repository labels: release notes: documentation for constrain_as_size fixed

@shazqadeer
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 13, 2024
@shazqadeer
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

tinglvv pushed a commit to tinglvv/pytorch that referenced this pull request May 14, 2024
Summary: Fixed typo in documentation. Trying to get familiar with the PR workflow for contributing to PyTorch.

Test Plan: None

Reviewers:

Subscribers:

Tasks:

Tags:

Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#125974
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants