Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymInt-ify unsqueeze_copy #125976

Closed
wants to merge 1 commit into from
Closed

SymInt-ify unsqueeze_copy #125976

wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor

@angelayi angelayi commented May 10, 2024 •
edited

Fixes #125853

I only half-know how to code c++ so please lmk if I did templating incorrectly 🙈
The reason I used a template is because the InferUnsqueezeGeometryResult struct gets used in a couple of other places, like for unsqueeze_quantized, but I wasn't sure if I should symint-ify those too.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 10, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125976

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 523a4d0 with merge base 96bdb7a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

larryliu0820
larryliu0820 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as CIs are green

@angelayi angelayi requested a review from ezyang May 13, 2024 18:35
@angelayi
Copy link
Contributor Author

@pytorchbot merge

@angelayi angelayi added the topic: not user facing topic category label May 14, 2024
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 14, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarun292 tarun292 tarun292 left review comments

@ezyang ezyang ezyang approved these changes

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
ci-td-distributed ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unsqueeze_copy doesn't seem to respect dynamic shapes
6 participants
@angelayi @facebook-github-bot @pytorchmergebot @ezyang @larryliu0820 @tarun292