New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AnalyzeTemporaryDtors from clang-tidy config #125985
Conversation
… in newer releases
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125985
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 01df3ab with merge base a5c93a6 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -61,6 +61,5 @@ readability-simplify-subscript-expr, | |||
readability-string-compare, | |||
' | |||
HeaderFilterRegex: '^(aten/|c10/|torch/).*$' | |||
AnalyzeTemporaryDtors: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this option does nothing, I think it's still dumped out by clang-tidy. Is it being removed in a future version and causing a hard error or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, clang-tidy 18 reports an error, so that I have to edit the config before analyzing code locally.
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Remove AnalyzeTemporaryDtors from clang-tidy config which is not used in newer releases. Pull Request resolved: pytorch#125985 Approved by: https://github.com/Skylion007
Remove AnalyzeTemporaryDtors from clang-tidy config which is not used in newer releases.