Enable UFMT format on test/test_utils.py #125996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125996
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 899133c with merge base 1115a25 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
shink
reviewed
May 14, 2024
test/test_utils.py
Outdated
Comment on lines
581
to
649
| p = subprocess.Popen(command, stdout=subprocess.PIPE, # noqa: P204 | ||
| stderr=subprocess.PIPE, shell=True) | ||
| p = subprocess.Popen( | ||
| command, | ||
| stdout=subprocess.PIPE, # noqa: P204 | ||
| stderr=subprocess.PIPE, | ||
| shell=True, | ||
| ) |
There was a problem hiding this comment.
the location of noqa may be wrong
There was a problem hiding this comment.
Maybe it's unnecessary, let me try to remove it.
ezyang
added
the
triaged
|
is clean |
|
@pytorchbot merge -i |
|
This PR needs to be approved by an authorized maintainer before merge. |
ezyang
approved these changes
May 15, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
Fixes some files in pytorch#123062 Run lintrunner on files: test/test_utils.py ```bash $ lintrunner -a --take UFMT --all-files ok No lint issues. Successfully applied all patches. Pull Request resolved: pytorch#125996 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some files in #123062
Run lintrunner on files:
test/test_utils.py