Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pytube3 for python 3 (could close #672) #693

Closed
wants to merge 1 commit into from

Conversation

maphew
Copy link

@maphew maphew commented Jul 26, 2020

No description provided.

@RONNCC
Copy link
Collaborator

RONNCC commented Jul 26, 2020

@maphew i believe that is a different library entirely so I'm a bit unclear if it fixes the root issue or replaces pytube with a different library when loading

We likely need to update our requirements.txt -- would definitely appreciate assistance here!

@maphew
Copy link
Author

maphew commented Jul 28, 2020

@RONNCC Thanks for the prompt attention. I didn't realize pytube & pytube3 are in a state of flux, once forked and now trying to come back together. The PR was just a naive implementation of the comments in #672. I'll see if I can find a way to help. There's also the fork-of-fork https://github.com/H4KKR/pytubeX.

A suggestion: create an issue out of the "actively calling for maintainers" part of the Readme. Pin it. Then reach out to folks like @H4KKR who have been active fixing bugs and making PRs in recent months.

@maphew
Copy link
Author

maphew commented Jul 28, 2020

(and: I'll close this PR after you've read it. It doesn't serve the right purpose)

@RONNCC
Copy link
Collaborator

RONNCC commented Jul 28, 2020

@RONNCC Thanks for the prompt attention. I didn't realize pytube & pytube3 are in a state of flux, once forked and now trying to come back together. The PR was just a naive implementation of the comments in #672. I'll see if I can find a way to help. There's also the fork-of-fork https://github.com/H4KKR/pytubeX.

I'm not really sure how they go together/work - need to dive into that more 😄

A suggestion: create an issue out of the "actively calling for maintainers" part of the Readme. Pin it. Then reach out to folks like @H4KKR who have been active fixing bugs and making PRs in recent months.
Good idea! Done in #698

@maphew maphew closed this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants