-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geographic north arrow orientation marker #6070
base: main
Are you sure you want to change the base?
Conversation
@@ -445,6 +445,64 @@ def create_axes_orientation_box( | |||
return actor | |||
|
|||
|
|||
def create_north_arrow(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be better as an example mesh rather than a tool here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, this looks tool.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6070 +/- ##
=======================================
Coverage 97.08% 97.09%
=======================================
Files 141 141
Lines 25940 25960 +20
=======================================
+ Hits 25185 25205 +20
Misses 755 755 |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
When plotting geographic scenes, a north arrow is often preferable to the typical right-hand-rule orientation marker.
These changes add a convenience method to add an orientation marker that is a in the style of a tradition geographic north arrow.
I somewhat arbitrarily chose the default color of this and I'm not totally loving it -- would appreciate suggestions for better colors.