Add caching to improve build time performance #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, thanks for your PR! However, having toyed around with buildx caching a few months ago, it always turned out to be slower than without cache, at least for Go projects where things are usually quick to download/test/build. What do you think? I can merge it and compare publish time by doing another commit on top too. If that turns out to be faster, I can modify the |
qdm12
force-pushed
the
adamus1red/build-caching
branch
2 times, most recently
from
b813db9
to
2973c56
Compare
- Cache base image layers only - Cache for verify job only - Do not cache for publish job since: - most of the work is cross compiling - go.mod often change between publish jobs - prevent bugs introduced due to the cache (unlikely)
qdm12
force-pushed
the
adamus1red/build-caching
branch
6 times, most recently
from
e835d1b
to
c7757c8
Compare
qdm12
force-pushed
the
adamus1red/build-caching
branch
from
c7757c8
to
c7f11b9
Compare
qdm12
force-pushed
the
master
branch
3 times, most recently
from
0ab3d3c
to
010634d
Compare
qdm12
force-pushed
the
master
branch
2 times, most recently
from
fd15083
to
5c166a6
Compare
qdm12
force-pushed
the
master
branch
2 times, most recently
from
bed663a
to
6a6b1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the builtin
cache-from/cache-tooptions from thedocker/buil-push-actionto write out the buildx cache.Using the github
actions/cacheaction the buildx cache is stored by github for future runs.