Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI #369

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve UI #369

wants to merge 2 commits into from

Conversation

MrNavaStar
Copy link

Nothing crazy here, just made things feel a bit cleaner. Might try and get the favicon to work at some point as it currently does not.

@MrNavaStar
Copy link
Author

Here's what it looks like, lmk what you think
image

qdm12
qdm12 reviewed Oct 7, 2022
View reviewed changes
Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!
Also excuse my late review, I was a bit way-over-busy recently.

Did you check how it looks like on mobile? It would be nice to have something scaling on both desktop and mobile ideally 😉

internal/server/ui/index.html Show resolved Hide resolved
internal/server/ui/index.html Show resolved Hide resolved
@MrNavaStar
Copy link
Author

MrNavaStar commented Oct 7, 2022 •
edited

I didn't look on mobile, kinda forgot about that as I don't use my phone much for those sorts of things. A mobile ui will probably need to be quite different as viewing tables on mobile is always a pain

Edit: after some more research (I'm not much of a front end dev haha) I can make the update status smaller (hopefully small enough to fit well on mobile) by moving some of the information into some kind of hover tooltip. I'll see if I can give it a try this weekend.

@qdm12 qdm12 force-pushed the master branch 3 times, most recently from 0ab3d3c to 010634d Compare January 19, 2024 11:43
@qdm12 qdm12 force-pushed the master branch 2 times, most recently from fd15083 to 5c166a6 Compare January 28, 2024 12:10
@qdm12 qdm12 force-pushed the master branch 2 times, most recently from bed663a to 6a6b1a8 Compare February 13, 2024 10:42
@fuse314
Copy link
Contributor

fuse314 commented Mar 19, 2024

Consider not linking the whole font-awesome library just for the Github icon.
Instead, please add the SVG code of the logo directly to the HTML file.

@MrNavaStar
Copy link
Author

lol I totally forgot about this PR. If anyone wants to take it over be my guest, I doubt I'll get around to finishing this.

@fuse314 fuse314 mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qdm12 qdm12 qdm12 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrNavaStar @fuse314 @qdm12