universal-query: Sketch request types pipeline #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coszio
commented
May 7, 2024
Comment on lines
+5
to
+11
| //! Pipeline of type conversion: | ||
| //! | ||
| //! 1. `rest::QueryRequest`, `grpc::QueryPoints`: rest or grpc request. Used in API | ||
| //! 2. `CollectionQueryRequest`: Direct representation of the API request, but to be used as a single type. Created at API to enter ToC. | ||
| //! 3. `ShardQueryRequest`: same as the common request, but all point ids have been substituted with vectors. Created at Collection | ||
| //! 4. `QueryShardPoints`: to be used in the internal service. Created for RemoteShard, converts to and from ShardQueryRequest | ||
| //! 5. `PlannedQuery`: an easier-to-execute representation. Created in LocalShard |
There was a problem hiding this comment.
This is the proposed type pipeline description
6 tasks
coszio
force-pushed
the
universal-query-at-shards
branch
from
8509242
to
48df0f8
Compare
agourlay
reviewed
May 13, 2024
| uint64 limit = 5; | ||
| } | ||
|
|
||
| Prefetch prefetch = 1; |
agourlay
reviewed
May 13, 2024
| } | ||
|
|
||
| message Prefetch { | ||
| Prefetch prefetch = 1; |
agourlay
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main idea: Each user request will be converted into a new type at each step of the search: API -> ToC -> Collection -> Shards.
This PR adds the types used at Shards level only, as well as a PoC of how the request will be handled at
LocalShard.Note that a significant amount of changed lines come from moving the
LocalShardimplementations ofdo_searchscrollandqueryto their own filesAll Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?