Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

universal-query: Add query() to ShardOperation trait #4210

Merged
merged 6 commits into from May 15, 2024

Conversation

coszio
Copy link
Contributor

@coszio coszio commented May 9, 2024

Needs #4209

Still some partial implementation for shard handling of query requests:

  • Adds a new query() required method on the ShardOperation trait, which receives the ShardQueryRequest type.
  • Includes the conversions needed to go from ShardQueryRequest to the grpc QueryShardPoints types
  • Moves itertools to the workspace dependencies

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@coszio coszio force-pushed the universal-query-at-shard-ops branch from 2368ae5 to 9680232 Compare May 14, 2024 15:43
@coszio coszio marked this pull request as ready for review May 14, 2024 16:16
lib/segment/src/vector_storage/query/mod.rs Outdated Show resolved Hide resolved
.into_iter()
.chunks(value.dim)
.into_iter()
.map(Iterator::collect::<Vec<_>>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fun one, haven't seen it like this before 😄

@coszio coszio force-pushed the universal-query-at-shard-ops branch from 54374eb to 70e8a47 Compare May 15, 2024 13:16
@coszio coszio merged commit bfa72bb into dev May 15, 2024
17 checks passed
@coszio coszio deleted the universal-query-at-shard-ops branch May 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants