Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime support #1090

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Datetime support #1090

wants to merge 6 commits into from

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Feb 9, 2024

  • Initial work

Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Feb 9, 2024 7:06pm

@davidfig davidfig changed the base branch from main to staging-2024-01 February 9, 2024 17:24
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1090 February 9, 2024 17:24 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1090 February 9, 2024 19:00 Inactive
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 89.63%. Comparing base (a6820f0) to head (1352548).
Report is 237 commits behind head on main.

Files Patch % Lines
quadratic-core/src/values/cellvalue.rs 50.00% 7 Missing ⚠️
quadratic-core/src/grid/file/current.rs 0.00% 3 Missing ⚠️
quadratic-core/src/values/convert.rs 0.00% 2 Missing ⚠️
...ratic-core/src/controller/operations/cell_value.rs 50.00% 1 Missing ⚠️
quadratic-core/src/formulas/criteria.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
- Coverage   89.68%   89.63%   -0.06%     
==========================================
  Files         131      131              
  Lines       22286    22308      +22     
==========================================
+ Hits        19988    19996       +8     
- Misses       2298     2312      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from staging-2024-01 to main February 12, 2024 20:27
@davidkircos davidkircos added high priority within weeks type: enhancement new feature or request labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority within weeks type: enhancement new feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants