Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url params #1281

Merged
merged 20 commits into from May 14, 2024
Merged

Url params #1281

merged 20 commits into from May 14, 2024

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Apr 15, 2024

Closes #732

  • cursor and sheet: ?x=0&y=1&sheet=name
  • code editor (if defined, editor is open): ?codeX=0&codeY=1&codeSheet=name
  • viewport rect ?vx=1&vy=2&vw=1000&vh=1001
  • redesign for the share dialog so it includes an option to include these variables (@jimniels)
  • discussion on whether to update the URL. Two options: (1) clear the URL after using these values; or (2) keep the URL updated with the latest information so you can always refresh or copy the URL to get back to your current state

Note: name for 1 and 2 is uri encoded and the comparison uses toLowerCase (so there's a chance it will conflict if you have two sheets with the same name except for cases)

@cla-bot cla-bot bot added the cla-signed label Apr 15, 2024
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview May 14, 2024 3:40pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1281 April 15, 2024 19:58 Inactive
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (7fa7cb7) to head (c172b24).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1281      +/-   ##
==========================================
+ Coverage   89.24%   90.06%   +0.82%     
==========================================
  Files         160      134      -26     
  Lines       26318    24288    -2030     
==========================================
- Hits        23488    21876    -1612     
+ Misses       2830     2412     -418     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1281 April 16, 2024 17:36 Inactive
Base automatically changed from core-web-worker to main April 18, 2024 21:11
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1281 April 24, 2024 16:07 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1281 April 24, 2024 16:08 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1281 May 6, 2024 13:49 Inactive
Copy link
Collaborator

@ddimaria ddimaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I'll let @davidkircos or @jimniels validate the UI.

@ddimaria
Copy link
Collaborator

ddimaria commented May 6, 2024

Screenshot 2024-05-06 at 7 56 23 AM

@davidfig should this move to an issue if not addressed in this PR?

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1281 May 7, 2024 12:53 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1281 May 7, 2024 12:54 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1281 May 14, 2024 15:28 Inactive
@davidkircos davidkircos merged commit 79c0a62 into main May 14, 2024
13 checks passed
@davidkircos davidkircos deleted the url-params branch May 14, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store sheet state in URL
4 participants