New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url params #1281
Url params #1281
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
+ Coverage 89.24% 90.06% +0.82%
==========================================
Files 160 134 -26
Lines 26318 24288 -2030
==========================================
- Hits 23488 21876 -1612
+ Misses 2830 2412 -418 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I'll let @davidkircos or @jimniels validate the UI.
@davidfig should this move to an issue if not addressed in this PR? |
Closes #732
?x=0&y=1&sheet=name
?codeX=0&codeY=1&codeSheet=name
?vx=1&vy=2&vw=1000&vh=1001
Note:
name
for 1 and 2 is uri encoded and the comparison uses toLowerCase (so there's a chance it will conflict if you have two sheets with the same name except for cases)