Inline formula

[davidfig]

• replace CellInput with InputEditor
• width should adjust automatically based on the width of the content
• div should never scroll or move from its anchor position
• formula should be activated with = as the first character w/proper syntax highlighting and hinting
• cell highlighting for formulas
• keyboard movement to input cell location
• mouse movement to input cell location
• bold and italic support
• multiplayer
• improve keep cursor visible logic

Limitations

• there's no way (I've found) to turn off the wheel event capture. This stops the grid from being able to mouse scroll when hovering over an open input box. This likely would require a hack/PR to monaco editor to add an option to remove the wheel handler

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quadratic	✅ Ready (Inspect)	Visit Preview	May 21, 2024 5:10pm

[codecov]

Codecov Report

Attention: Patch coverage is 98.58156% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.34%. Comparing base (eb54932) to head (10651b1).

Files	Patch %	Lines
quadratic-core/src/formulas/ast.rs	85.71%	1 Missing ⚠️
quadratic-core/src/formulas/functions/macros.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
+ Coverage   89.24%   89.34%   +0.10%     
==========================================
  Files         160      160              
  Lines       26318    26425     +107     
==========================================
+ Hits        23488    23610     +122     
+ Misses       2830     2815      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davidkircos]

Bug:
Start an inline formula, type something, expand to full editor.
While the inline editor is still open, press / on a different cell. Select Python
The content from the inline formula will appear in the python formula

[jimniels]

When using Google Sheets or Excel, you can select multiple cells at once is done by holding the CMD key and then clicking on individual cells

CleanShot.2024-05-20.at.11.56.14.mp4

Quadratic does not do this. Holding down CMD and clicking doesn't make multiple selections. It only moves the selection.

CleanShot.2024-05-20.at.11.56.36.mp4

Seems like we should match the functionality of excel/sheets.

[jimniels]

When you delete the last closing parenthesis, then try to make a selection with the cursor, it seems to cancel your entire selection and breaks you out of interactive editing mode — presumably because it inserts the cell reference at the beginning of the cell

CleanShot.2024-05-20.at.12.04.55.mp4

Google docs doesn't do this.

CleanShot.2024-05-20.at.12.06.10.mp4

[jimniels]

Code cell outlines disappear before I've changed anything in my formula. They shouldn't redraw until I run the formula anew

CleanShot.2024-05-20.at.12.33.26.mp4

We don't do that with other cell types (like python). Seems like the outlines should stay until the formula re-runs.

[jimniels]

I'm 👍 on the functionality of this