Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag cells to move #1332

Merged
merged 18 commits into from May 13, 2024
Merged

Drag cells to move #1332

merged 18 commits into from May 13, 2024

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented May 3, 2024

  • hover in the top-left corner of the cursor origin shows a drag cursor
  • click on that corner starts a move
  • during cell moving, the floating context menu is hidden
  • show UI (skeleton box) when dragging cell
  • cancel move on escape
  • cut-and-paste cells when releasing move
  • moving to the viewport borders scrolls the viewport

@cla-bot cla-bot bot added the cla-signed label May 3, 2024
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview May 8, 2024 7:02pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1332 May 3, 2024 19:10 Inactive
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 89.24%. Comparing base (6f5438b) to head (7859a7f).

Files Patch % Lines
...dratic-core/src/controller/operations/operation.rs 0.00% 2 Missing ⚠️
.../execution/execute_operation/execute_move_cells.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1332      +/-   ##
==========================================
+ Coverage   89.15%   89.24%   +0.08%     
==========================================
  Files         159      160       +1     
  Lines       26240    26319      +79     
==========================================
+ Hits        23395    23489      +94     
+ Misses       2845     2830      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1332 May 5, 2024 15:40 Inactive
@davidfig davidfig marked this pull request as ready for review May 5, 2024 15:44
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1332 May 6, 2024 11:39 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1332 May 6, 2024 11:45 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1332 May 6, 2024 14:31 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1332 May 7, 2024 12:02 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1332 May 7, 2024 12:12 Inactive
Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-05-08 at 09 42 19@2x

Red dot visible when resizing

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1332 May 8, 2024 18:50 Inactive
@davidkircos davidkircos merged commit 957ce68 into main May 13, 2024
13 checks passed
@davidkircos davidkircos deleted the move-cells branch May 13, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants