Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Create a new Job to scan SFTP folders #2123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ManuelLopezNavarrete
Copy link

  • Create a base class to share the common keys with DirectroyScaner

 - Create a base class to share the common keys with DirectroyScaner
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ManuelLopezNavarrete
Copy link
Author

I don't now if there are any issue if i refactor the original DirectroyScaner creating a base class to share the common logic.
If there isn't any issue i will like to create a base class to DirectoryScanJobModel to.

If you prefer to have separate implementation independence of the duplication of code, i will do a rollback an duplicate the necessary code.

@ManuelLopezNavarrete
Copy link
Author

I'don't know how to interpret the qodan-scan and reading the log i understand, i need an access Token?

@lahma
Copy link
Member

lahma commented Sep 6, 2023

You can ignore that check, it has some problems not related to PR content.

@A9G-Data-Droid
Copy link
Contributor

I don't recommend using SSH.NET at all, let alone including such a large chunk in Quartz. It seems to be way out of scope for a scheduling library. SSH.NET has a bunch of problems and is way behind on development. I recently replaced SSH.NET with WinSCP in my own projects to solve a connection hang issue. I no longer see the hang issue and the performance is 10x faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants