Raise exception in case of duplicated trigger in xml #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, in case of two triggers with the same name, Quartz ignores the first trigger which misleading us why the first trigger didn't fire. In such case, the xml config is invalid and qaurtz should raises exception
lahma
requested changes
Aug 31, 2019
| @@ -405,6 +407,13 @@ protected virtual void ProcessInternal(string xml) | |||
| } | |||
| } | |||
|
|
|||
| // check for triggers with the same name | |||
| var duplicatedTriggers = triggerEntries.GroupBy(c => c.Item.name).Where(c => c.Count() > 1); | |||
There was a problem hiding this comment.
I think the grouping should be done using name and group? Trigger's identity is based on both name and group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in case of multiple triggers with the same name in xml files, Quartz ignores the first ones
which misleading us why the first triggers didn't fire. In such case, the xml config
is invalid and qaurtz should raises exception, so that we will know what is wrong