chore(core): add config hot-reload subsystem and implementation for pgwire credential changes #4168
Conversation
sklarsa
changed the title
sklarsa
changed the title
[PR Coverage check]😍 pass : 38 / 57 (66.67%) file detail
|
|
@bluestreak01 here's an update on this. I just merged master into this branch, fixed merge conflicts, and all tests pass (with the exception of the flaky It looks like I was in the process of moving my The Bootstrap and ServerMain plumbing code is working as expected for the As for the cross-platform filewatcher stuff, here is where we are.
I'm happy to sync with you on this when you have time. I'd love to finally finish this thing. |
|
GitHub Actions - Rebuild Native Libraries seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
on close() the closing thread writes into a pipe. this is meant to unblock the blocked polling thread. in order for this to work we have to register to receive read-ready events from the pipe. this way the closing thread set the `closed` flag and writes into the pipe. this notifies the poller, which checks the closed() flag, realizes it's closed, exit waitForChange() and finally unblock the latch the closing thread is waiting for.
This swaps out PropServerConfiguration usage with ReloadingPropServerConfiguration. It should be a no-op, in preparation for hot-reloading config
Instead of inheriting from PropServerConfiguration, I decided to wrap it in a new class to avoid moving code around too much, since the validation logic is in the PropServerConfiguration constructor