Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): [I18N help wanted!] Update TSBS benchmark and add explainer #4297

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

oliver-daniel
Copy link
Contributor

@oliver-daniel oliver-daniel commented Mar 14, 2024

Replaces the previous benchmark comparing QuestDB to its competitors over increasing number of workers, to one comparing ingest speeds with fixed compute and increasing cardinality.

IMPORTANT: as the PR stands, only the English-language README has been updated. Help would be sincerely appreciated to bring this improvement to our READMEs in:

  • zh-cn (Mandarin) (thank you @1998code!)
  • zh-hk (Cantonese) (thank you @terasum!)
  • ar-dz (Arabic)
  • it-it (Italian) (thank you @TheZalRevolt!)
  • ua-ua (Ukrainian)
  • es-es (Spanish)
  • pt (Portuguese)
  • ja-ja (Japanese)
  • tr-tr (Turkish) (thank you @kerimsenturk5734!)
  • hn-in (Hindi) (thank you @heysagnik!)

NOTE FOR TRANSLATORS

Part of this PR introduces a new image, .github/questdb7.3.10-tsbs-benchmark.png, which is NOT available on the master branch. Please base your PRs off of this branch (doc/how-questdb-compares) and ensure that all images appear properly before submitting. If you've already created your PRs, try rebasing your changes off of this branch and ensure that your PR target branch is correct. Thank you, and apologies for previous lack of clarity!

@oliver-daniel oliver-daniel added Help wanted Assistance or additional information is wanted Good first issue A great place to get familiar with the codebase Documentation Missing or suggested improvements for documentation labels Mar 14, 2024
@oliver-daniel oliver-daniel changed the title [I18N help wanted!] Update TSBS benchmark and add explainer docs(core): [I18N help wanted!] Update TSBS benchmark and add explainer Mar 14, 2024
README.md Show resolved Hide resolved
goodroot
goodroot previously approved these changes Mar 15, 2024
Copy link
Contributor

@goodroot goodroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oliver-daniel
Copy link
Contributor Author

👋 Pinging a handful of folks who were major contributors to previous i18n efforts!

Just wanted to bring these changes to your attention, and if you find yourself with the time and energy, additions to this PR (or separate PRs) to bring the READMEs back in sync would be sincerely appreciated. Your work helps make QuestDB accessible to linguistic communities worldwide!

@HouariZegai
@heysagnik
@TheZal
@4N1Z
@Jovin247
@kerimsenturk5734
@bsmth @dragonlee8 @pswu11 @terasum
@1998code

mtopolnik
mtopolnik previously approved these changes Mar 22, 2024
@TheZalRevolt
Copy link

I'll be happy to help for the italian part but unfortunately I will be on holiday without the pc untill the 3rd of april, is that ok?

@kerimsenturk5734
Copy link
Contributor

I glad to update for Turkish part. I will be updating as soon as possible.

@terasum
Copy link
Contributor

terasum commented Mar 22, 2024

I'll help the Simplify-Chinese version, I will submit ASAP :).

@1998code
Copy link
Contributor

1998code commented Mar 22, 2024

zh-hk updated 🙏

@oliver-daniel
Copy link
Contributor Author

Hi friends, waking up to so many enthusiastic replies warms my language-loving heart. <3

Please be advised that I could have been a bit more clear about how to go about submitting PRs for your contribution -- TLDR it's important to base your work on the branch of this PR, doc/how-questdb-compares, rather than master in order to include a new image that is not yet available on the main branch. That being said, once this PR is merged, the image should be available and the link will work in your PR. So, don't fret too much if you started off master, as this English PR will likely be merged first.

Thank you, grazie, 谢谢, 謝謝, etc.!

@1998code
Copy link
Contributor

zh-hk translation => (#4332) fixed branch and images.

P.S. I cannot see the doc/how-questdb-compares branch in my old fork, even though I synced it many times (no matter in the website / GitHub desktop). After all the tries, I deleted the repo and fork again, and then it can show again 🙈

@terasum
Copy link
Contributor

terasum commented Mar 22, 2024

Fixed zh-cn : #4334

By the way, the doc/how-questdb-dompares branch is behind master, merge our PR first then rebase on to the master may be better, thank you!

@heysagnik
Copy link
Contributor

updated hn-in

@kerimsenturk5734
Copy link
Contributor

kerimsenturk5734 commented Mar 23, 2024

Hi. I am going to fork the project from doc/how-questdb-compares branch, update the Turkish readme file (for me) according to english version on this branch and create a PR by mentioning this PR. Is that what should i do? I ask that to be sure. Please correct me if i am wrong.

@oliver-daniel
Copy link
Contributor Author

Hey @kerimsenturk5734, sounds perfect. Thank you!

@TheZalRevolt
Copy link

Done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Missing or suggested improvements for documentation Good first issue A great place to get familiar with the codebase Help wanted Assistance or additional information is wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants