feat(ilp): breaking change💥 - ILP and TextImport create VARCHAR instead of STRING columns #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumns ILP implicit column creation for string data now defaults to VARCHAR columns instead of STRING. VARCHAR type uses less disk space and is faster than STRING for most operations. Most users should use VARCHAR columns instead of STRING columns. If for any reason VARCHAR type is not yet usable for a given use case, then you can opt-out by setting this configuration option: line.use.legacy.string.default=true. You can also explicitly create a target table instead of relying on ILP implicit creation.
jerrinot
changed the title
jerrinot
changed the title
nwoolmer
added
ILP
ideoma
approved these changes
May 8, 2024
ideoma
previously approved these changes
May 8, 2024
ideoma
previously approved these changes
May 16, 2024
|
@ideoma I resolved a merge conflict and it dismissed your review. please re-approve. thanks! |
ideoma
approved these changes
May 16, 2024
[PR Coverage check]😍 pass : 55 / 57 (96.49%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text import and ILP now create VARCHAR columns instead of STRING columns. VARCHAR type uses less disk space and is faster than STRING for most operations. Most users should use VARCHAR columns instead of STRING columns.
If VARCHAR type is not yet usable for a given use case, then you can opt out by setting this configuration option:
cairo.legacy.string.column.type.default=true.