POC: Setting thread affinity on indexer threads #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix windows build
* Fix windows build
…u-set-pinning # Conflicts: # src/directory/mmap_directory.rs # src/lib.rs
|
Have you measured a benefit? |
|
@fulmicoton I have yet to get around to testing the general performance change this has, I wanted this particular feature to allow some better control over the indexing threads preventing indexers from interfering with searchers since tantivy spawns its own set of threads internally unlike the searchers. The main advantage of this change is that you could spawn say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I wanted to test some smarter ways of balancing a large number of indexers in a multi-tenant situation without affecting searchers and decided to test out specifying specifically what CPU set the indexers could run on, giving searchers their own unaffected CPU set.
This is mostly an idea rather than a super useful feature, I've not included specifying the searcher CPU set as I'm not sure the best way to implement that in a way that doesn't result in extra calls when it doesn't need to be (i.e. SingleThreaded)