-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compact doc #2402
compact doc #2402
Conversation
fix serde_json date Value implementation
use u32 for Addr Remove the 3 byte addressing limitation and use VInt instead
#[derive(Clone, Copy, Default)] | ||
#[repr(packed)] | ||
/// The value type and the address to its payload in the container. | ||
pub struct ValueAddr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect it does not have to be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll probably add an API later for concat fields, so we can just take the ValueAddrs and add them to a Field, instead of operating on the JSON values
Replaces TantivyDocument with a version that is more compact, by storing all data in two vecs. (similar to tape in simd_json)
This new Document has a lower memory footprint, but has a limitation:
Field
can't exceedu16::MAX
This PR also fixes an issue on the
Value
implementation onserde_json::Value
, which did not handle date parsing on strings