Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] add new prop to SelectContent to account for shadow dom rendering #2712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abrehamgezahegn
Copy link

@abrehamgezahegn abrehamgezahegn commented Feb 18, 2024

Description

Fix for #2606 .
Select arrow navigation depends on document.activeElement. But if the select is rendered in shadow dom, document.activeElement returns top level element in the shadow dom. This breaks the keyboard navigation.

I edited the keyboard handler to check if select is in shadow dom then get the active element from it.
B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant