feat: make data-state more explicit
#2716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
data-statecomposition issue when composing multiple primitives withasChild#602Reading the comments from the discussion, I made the
date-statemore explicit by adding the name of the radix component. This feature will help the namespace ofdata-statebe more clean.I think leaving the
data-stateas a legacy and addingdata-[component]-statewill be good for now. For next major update, we can drop the support for thedata-state.If the maintainers agree on this approach, I can update all the storybook examples to new
data-staterepresentation as well. Please, any feedback is appreciated!!!