fix: Prevent infinite tabbing loop by checking for other active elements when tabbing out #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspalevic
requested review from
benoitgrelard,
andy-hook,
vladmoroz and
lucasmotta
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an issue with the radio group component that causes an infinite tabbing loop when it includes another focusable element.
In the following example, there is a link within the radio group. When the second radio group item is selected and a user tries to tab out (with
shift+tab), the focus then goes to the Link element. After hittingshift+tabagain, the focus goes back to the selected radio group item. And the user is stuck in a loop.before.mov
This PR begins to only signify that the user is tabbing out as long as the active element is not contained within the radio group. This prevents auto-focusing to the selected radio group item and allows the user to tab out of the radio group.
after.mov